Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/2.7.0 #200

Merged
merged 7 commits into from
Mar 25, 2024
Merged

chore/2.7.0 #200

merged 7 commits into from
Mar 25, 2024

Conversation

Baroshem
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@Baroshem Baroshem linked an issue Mar 24, 2024 that may be closed by this pull request
Copy link

netlify bot commented Mar 24, 2024

Deploy Preview for nuxt-cloudinary-module ready!

Name Link
🔨 Latest commit f692759
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-cloudinary-module/deploys/66018dda9d85510008820982
😎 Deploy Preview https://deploy-preview-200--nuxt-cloudinary-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Baroshem Baroshem changed the title adding ability to pass in global module configurations chore/2.7.0 Mar 24, 2024
@Baroshem Baroshem linked an issue Mar 24, 2024 that may be closed by this pull request
@Baroshem Baroshem linked an issue Mar 24, 2024 that may be closed by this pull request
@colbyfayock
Copy link
Collaborator

@Baroshem this seems to work great! i added a few comments

im also having trouble getting the cname to work on the video player for some reason, but after debugging, i dont believe it has anything to do with your code taht i can find yet, so im unsure why it's not working, but it worked perfectly fine with CldImage with a module-level config

still looking into it

@colbyfayock
Copy link
Collaborator

i think i found the issue - those configuration properties might have been a relatively recent addition? or at a minimum, a bug was fixed, where after upgrading to the latest VideoPlayer version, it seems that everything works as expected

so updating 1.9.4 to 1.10.6 inside CldVideoPlayer (and the docs that reference it)

@colbyfayock
Copy link
Collaborator

heres what i tested with, though it wont work, you'll be able to see in the web console the URLs with spacejelly.dev in the front

export default defineNuxtConfig({
  modules: ['../src/module'],
  cloudinary: {
    cloudName: 'nuxt-cloudinary',
    url: {
      cname: 'spacejelly.dev',
      secureDistribution: 'spacejelly.dev',
      secure: true,
      privateCdn: true
    }
  }
})

@Baroshem Baroshem linked an issue Mar 25, 2024 that may be closed by this pull request
@Baroshem Baroshem merged commit e2d04a3 into main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants