Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reportPassWords add-on #4818

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Conversation

nvdaes
Copy link
Contributor

@nvdaes nvdaes commented Dec 30, 2024

No description provided.

@nvdaes
Copy link
Contributor Author

nvdaes commented Dec 30, 2024

I request to remove this add-on. I agree with the comment posted by @michaelDCurran on this pull request:

nvaccess/nvda#17481

When this is removed from the store, my plan is to make a commit in mrConfig repo to unregister the add-on from the translations system, and removing tags dev and stable from the SVN repo, so that this add-on is not shown on the website.

@seanbudd
Copy link
Member

seanbudd commented Jan 3, 2025

@nvdaes are you sure you want to remove this? just because this is something we haven't accepted into core yet doesn't mean it isn't a utility for users. I just want to be clear there's no expectation from NV Access to remove this from the store.

@nvdaes
Copy link
Contributor Author

nvdaes commented Jan 11, 2025

@seanbudd , I was on hollidays. Sorry for the delay. I thought that my reply reached this PR. I tried to reply via email from BlindShell mobile.
Yes, feel free to remove this add-on. I'd like to find a secure way for this feature. I am strongly pledged with secure add-ons too.
I think that nobody should type a password controlling a remote computer, which may be intercepter in multiple ways. But I didn't realise about this issue and I prefer to work trying that NVDA includes this in the core when possible, not in an add-on maintained by me. NV Access have more knowledge, resources and obviously is and should be more trusted than me, in particular about security.

@seanbudd seanbudd merged commit 9fca5eb into nvaccess:master Jan 12, 2025
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
Commit message:
Remove reportPassWords add-on (#4818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants