Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(305172): add MobSF security scan on android and iOS builds for staging and prod #37

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Arieldelossantos
Copy link

@Arieldelossantos Arieldelossantos commented Jun 25, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

add MobSF security scan on android build staging and prod

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and src/cli/CLI.md if you made changes to templating.
    • Update AzurePipelines.md and src/app/README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

Product Backlog Item 305172: [Dev] [Mobile Security] Integrate MobSF in FlutterApplicationTemplate

@Soap-141
Copy link
Contributor

@Arieldelossantos Please rebase it on main, I just merged a CI/CD fix.

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/integrate-mobsf-pipeline branch from 97cf01b to 761a74f Compare June 25, 2024 17:47
@Arieldelossantos Arieldelossantos changed the title feat(#305172): add MobSF security scan on android build staging and prod feat(305172): add MobSF security scan on android build staging and prod Jun 25, 2024
Copy link
Contributor

@Soap-141 Soap-141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also be done for iOS? And is this something we want for newer applications when generating from the template? It would also be nice to have some documentation about it, I currently don't know what it does exactly.

src/cli/CHANGELOG.md Outdated Show resolved Hide resolved
build/steps-build-android.yml Outdated Show resolved Hide resolved
@Arieldelossantos
Copy link
Author

Should it also be done for iOS? And is this something we want for newer applications when generating from the template? It would also be nice to have some documentation about it, I currently don't know what it does exactly.

yes, i'm working now on the iOS integration i'll probably create the PR tomorrow EOD

build/templates/mobsf-android-scan.yml Outdated Show resolved Hide resolved
build/variables.yml Outdated Show resolved Hide resolved
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/integrate-mobsf-pipeline branch from 761a74f to abb21f3 Compare June 26, 2024 15:08
@Arieldelossantos
Copy link
Author

@lesterbotello @Soap-141 i've updated the PR with the iOS implementation

@Arieldelossantos Arieldelossantos changed the title feat(305172): add MobSF security scan on android build staging and prod feat(305172): add MobSF security scan on android and iOS builds for staging and prod Jun 26, 2024
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/integrate-mobsf-pipeline branch 5 times, most recently from 0a944f9 to 6ba3b7c Compare June 26, 2024 19:14
build/variables.yml Outdated Show resolved Hide resolved
build/variables.yml Outdated Show resolved Hide resolved
src/cli/CHANGELOG.md Outdated Show resolved Hide resolved
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/integrate-mobsf-pipeline branch 2 times, most recently from c0c0b8b to 9106579 Compare July 3, 2024 13:15
src/cli/CHANGELOG.md Outdated Show resolved Hide resolved
build/stage-build-security-android.yml Outdated Show resolved Hide resolved
build/stage-build-security-android.yml Outdated Show resolved Hide resolved
build/variables.yml Show resolved Hide resolved
src/cli/CHANGELOG.md Show resolved Hide resolved
build/stage-build-security-ios.yml Outdated Show resolved Hide resolved
build/variables.yml Outdated Show resolved Hide resolved
build/templates/mobsf-ios-scan.yml Outdated Show resolved Hide resolved
build/stage-build-security.yml Outdated Show resolved Hide resolved
build/variables.yml Show resolved Hide resolved
build/variables.yml Outdated Show resolved Hide resolved
build/variables.yml Outdated Show resolved Hide resolved
@lesterbotello lesterbotello force-pushed the dev/arde/integrate-mobsf-pipeline branch from b6ee09a to 4d73102 Compare July 15, 2024 12:43
@lesterbotello lesterbotello merged commit 4c4b702 into main Jul 16, 2024
16 checks passed
@lesterbotello lesterbotello deleted the dev/arde/integrate-mobsf-pipeline branch July 16, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants