Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all triggers on the api integration test pipeline #382

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

takla21
Copy link
Contributor

@takla21 takla21 commented Dec 12, 2023

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

I've made sure that the Api Integration pipeline is not triggered after a commit for any branch.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@carlh98
Copy link
Contributor

carlh98 commented Dec 12, 2023

@takla21 I think the commit should use fix or chore instead of ci.
is that correct @jeanplevesque?

@jeanplevesque
Copy link
Member

@takla21 I think the commit should use fix or chore instead of ci. is that correct @jeanplevesque?

Correct.

@jeanplevesque
Copy link
Member

@takla21
image

@takla21
Copy link
Contributor Author

takla21 commented Dec 12, 2023

@jeanplevesque @carlh98 I though that ci would also count as a Path increment. Also, that's my reflex to cross item in the checklist as an acknowledgment of the item, but didn't applied in this PR. I've uncrossed them though

Copy link
Contributor

@Soap-141 Soap-141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could rename the PR to the actual commit :)

@takla21
Copy link
Contributor Author

takla21 commented Dec 12, 2023

@jeanplevesque nvm I misunderstood the new PR checklist. I've made sure to check them all (at least the always applicable) and add a notes in the changelog

@takla21 takla21 changed the title ci: remove all triggers on the api integration test pipeline fix: remove all triggers on the api integration test pipeline Dec 12, 2023
@takla21 takla21 merged commit e7e1d24 into main Dec 12, 2023
14 checks passed
@takla21 takla21 deleted the dev/keta/apitestci branch December 12, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants