Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(293338): fix changeLog file url on PR template #403

Merged
merged 1 commit into from
May 16, 2024

Conversation

Arieldelossantos
Copy link
Contributor

@Arieldelossantos Arieldelossantos commented May 1, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

fix changeLog file url on PR template

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

NA

Internal Issue (If applicable):

NA

@Arieldelossantos Arieldelossantos self-assigned this May 1, 2024
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fix-changelog-file-url branch from c2e8a6e to 3f103b5 Compare May 1, 2024 21:13
@carlh98 carlh98 force-pushed the dev/arde/fix-changelog-file-url branch from 3f103b5 to 2194102 Compare May 16, 2024 19:12
@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fix-changelog-file-url branch from 2194102 to 1d5b649 Compare May 16, 2024 19:15
@Arieldelossantos Arieldelossantos merged commit 7da83f2 into main May 16, 2024
14 checks passed
@Arieldelossantos Arieldelossantos deleted the dev/arde/fix-changelog-file-url branch May 16, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants