-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add forcedupdate firebase implementation #409
base: main
Are you sure you want to change the base?
Conversation
2d8513e
to
bfeed37
Compare
729ac11
to
f91e23b
Compare
f91e23b
to
a7dc31f
Compare
b9f6b92
to
2ba7586
Compare
@@ -55,18 +53,6 @@ private static IServiceCollection AddUserProfile(this IServiceCollection service | |||
return services.AddSingleton<IUserProfileRepository, UserProfileRepositoryMock>(); | |||
} | |||
|
|||
private static IServiceCollection AddMinimumVersion(this IServiceCollection services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to keep those for the functional tests to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The services exist in the view layer, this doesnt have access to the service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could try to create some sort of thing that would get the viewservice here, would that be something we really want to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests don't use anything from the View layer. So I guess this adds to my original question. 😋
GitHub Issue: #
Proposed Changes
Description
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.md
andTemplateConfig.md
if you made changes to templating.AzurePipelines.md
andAPP_README.md
if you made changes to pipelines.Diagnostics.md
if you made changes to diagnostic tools.Architecture.md
and its diagrams if you made architecture decisions or if you introduced new recipes.doc/
folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):