Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate firebase app distribution in the template for internal distribution [feature branch] #411

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

takla21
Copy link
Contributor

@takla21 takla21 commented Jun 13, 2024

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

I'm integrating Firebase app distribution as a potential replacement for AppCenter.

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@takla21 takla21 force-pushed the dev/keta/firebase branch 2 times, most recently from 24070dd to c49545b Compare June 13, 2024 19:21
@takla21 takla21 marked this pull request as ready for review June 13, 2024 19:22
@takla21 takla21 requested a review from jeanplevesque June 13, 2024 19:22
.azure-pipelines-canary.yml Show resolved Hide resolved
build/stage-release-firebase.yml Outdated Show resolved Hide resolved
@takla21 takla21 force-pushed the dev/keta/firebase branch from c49545b to 80e8734 Compare June 14, 2024 14:07
@takla21 takla21 merged commit d3181a9 into feature/firebaseappdist Jun 14, 2024
14 checks passed
@takla21 takla21 deleted the dev/keta/firebase branch June 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants