Integrate Testfairy app distribution in the template for internal distribution [feature branch] #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanplevesque
requested changes
Sep 17, 2024
.azure-pipelines.yml
Outdated
| parameters: | ||
| applicationEnvironment: Production | ||
| deploymentEnvironment: GooglePlay | ||
| # Use this to schedule a build at defined days and times |
There was a problem hiding this comment.
Why does it look like every line changed?
There was a problem hiding this comment.
It was caused by VS Code "Format on save"
.azure-pipelines-canary.yml
Outdated
| - template: build/stage-release-appstore.yml | ||
| parameters: | ||
| applicationEnvironment: Staging | ||
| trigger: # Start a new run as soon as a "canaries/build/(...)" branch is created. |
There was a problem hiding this comment.
Why does it look like every line changed?
APP_README.md
Outdated
| ## Additional Information | ||
|
|
||
| TODO: Add any other relevant information. e.g. You could link to your _Definition of Done_, more documentation, UI mockups, etc. | ||
| # Your Project Name |
There was a problem hiding this comment.
Same here. Perhaps your line endings are wrong.
There was a problem hiding this comment.
Yeah there's definitely a problem. This comment applies to almost every file.
build/fastlane/Gemfile.lock
Outdated
| @@ -0,0 +1,218 @@ | |||
| GEM | |||
There was a problem hiding this comment.
Should this file be excluded from source control? It seems generated.
There was a problem hiding this comment.
This ensures that you have the same versions all the time and that it don't breaks because of a new version of a dependency.
rfabre
force-pushed
the
dev/rofa/testfairy-deployment
branch
6 times, most recently
from
384b1ee to
e668bfe
Compare
rfabre
force-pushed
the
dev/rofa/testfairy-deployment
branch
from
e668bfe to
c61bfc2
Compare
…stfairy stage release file.
rfabre
force-pushed
the
dev/rofa/testfairy-deployment
branch
from
2dc691c to
6bad816
Compare
rfabre
force-pushed
the
dev/rofa/testfairy-deployment
branch
from
6bad816 to
7c046b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
I'm integrating Testfairy app distribution(https://www.testfairy.com/app-distribution) as a potential replacement for AppCenter.
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.mdandTemplateConfig.mdif you made changes to templating.AzurePipelines.mdandAPP_README.mdif you made changes to pipelines.Diagnostics.mdif you made changes to diagnostic tools.Architecture.mdand its diagrams if you made architecture decisions or if you introduced new recipes.doc/folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):