Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace AppCenter in favor of Firebase App Distribution in UnoA… #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lee31416
Copy link
Contributor

…pplicationTemplate

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Replacing appcenter with firebase app distribution

Impact on version

  • Major
    • The template structure was changed.
  • Minor
    • New functionalities were added.
  • Patch
    • A bug in behavior was fixed.
    • Documentation was changed.

PR Checklist

Always applicable

No matter your changes, these checks always apply.

  • Your conventional commits are aligned with the Impact on version section.
  • Updated CHANGELOG.md.
    • Use the latest Major.Minor.X header if you do a Patch change.
    • Create a new Major.Minor.X header if you do a Minor or Major change.
    • If you create a new header, it aligns with the Impact on version section and matches what is generated in the build pipeline.
  • Documentation files were updated according with the changes.
    • Update README.md and TemplateConfig.md if you made changes to templating.
    • Update AzurePipelines.md and APP_README.md if you made changes to pipelines.
    • Update Diagnostics.md if you made changes to diagnostic tools.
    • Update Architecture.md and its diagrams if you made architecture decisions or if you introduced new recipes.
    • ...and so forth: Make sure you update the documentation files associated to the recipes you changed. Review the topics by looking at the content of the doc/ folder.
  • Images about the template are referenced from the wiki and added as images in this git.
  • TODO comments are hints for next steps for users of the template and not planned work.

Contextual

Based on your changes these checks may not apply.

  • Automated tests for the changes have been added/updated.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Lee31416 Lee31416 force-pushed the dev/topi/integrate-firebase-app-distribution branch 3 times, most recently from 57dc1de to 3124004 Compare December 20, 2024 07:56
applicationEnvironment: Staging
serviceConnectionKeyFileName: $(FirebaseAppDistributionServiceConnection)
pathToAab: '$(Pipeline.Workspace)/$(artifactName)/*Signed.aab'

- stage: AppCenter_TestFlight_Staging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppCenter needs to be replaced.

@@ -80,6 +80,16 @@ stages:
iosVariableGroup: 'ApplicationTemplate.Distribution.Internal.iOS'
BannerVersionNameText: "STAGING"

- stage: Firebase_App_Distribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have a new stage, you need to change the existing one to replace AppCenter in favor of Firebase app distribution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im currently testing I was planning to remove them after

@Lee31416 Lee31416 force-pushed the dev/topi/integrate-firebase-app-distribution branch 9 times, most recently from 6532d13 to ef41124 Compare December 23, 2024 05:05
@Lee31416 Lee31416 force-pushed the dev/topi/integrate-firebase-app-distribution branch from ef41124 to 8611500 Compare December 23, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants