Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for maximum number of NAT Gateways #2

Merged
merged 1 commit into from
May 17, 2024

Conversation

alextrepa
Copy link
Contributor

@alextrepa alextrepa commented May 17, 2024

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

What is the current behavior?

It is not possible to set the upper limit on the number of Nat Gateways that will be created by the template. If enabled, 1 gateway will be created per availibility zone.

What is the new behavior?

It is now possible to set an upper limit on the number of Nat Gateways. This can help keep lower the cost but will also lower the availibility of the app.

Checklist

Please check that your PR fulfills the following requirements:

  • Documentation has been added/updated.
  • Automated tests for the changes have been added/updated.
  • Commits have been squashed (if applicable).
  • Updated BREAKING_CHANGES.md (if you introduced a breaking change).

@alextrepa alextrepa requested a review from jbonnier May 17, 2024 14:14
@alextrepa alextrepa merged commit c7be1ff into main May 17, 2024
3 checks passed
@alextrepa alextrepa deleted the feature/max-nats branch May 17, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants