chore: pnpm version control by corepack #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This is because the version is automatically determined by referring to the packageManager property of package.json automatically. https://github.com/pnpm/action-setup/tree/v2.4.0/#version
✅ Deploy Preview for jest-preview-chinese canceled.
|
✅ Deploy Preview for jest-preview-library canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/ Motivation (TLDR;)
When I set up jest-preview on my local environment, it changed the lockfile version in pnpm-lock.yml. When I looked it up, jest-preview's pnpm was v7. The current latest version of pnpm is v8.6.12.
I made it possible to version control pnpm by utilizing the function by corepack. This is also how repositories like next.js and react-hook-form manage it.
https://github.com/vercel/next.js/blob/canary/contributing/core/developing.md#developing
https://github.com/react-hook-form/react-hook-form/blob/master/package.json#L147
Chores