Always add a space after status_symbol #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! As mentioned in #35 (which this will close), this was because the statusline proof-of-concept code came from my own setup, which uses a double-wide symbol for hints and looks wrong with a space added. I'm happy to merge this and make handling of the different diagnostics types more consistent, but perhaps we should also change the default symbol ( lsp-status.nvim/lua/lsp-status.lua Line 9 in 925acda |
|
Ah okay, I understand. So we'd need to change the default |
|
That's one option, I suppose. I more meant that we'd just change the default |
maddiemort
force-pushed
the
nerosnm/always-add-space
branch
from
e79d2e4
to
cecfd77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed once I'd set this up that when I only had hints, no space was being added after the status symbol:
I expected to find when I looked in the code that this was unintentional, but this looks pretty intentional. However, I think this should be considered a bug, because it treats hints differently from the other types of diagnostics.
This change makes the diagnostics when there are only hints...
...render the same as when there are other types of diagnostics too, e.g. hints and errors: