fix: restore user's UI options when switching tabs 2 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarap
force-pushed
the
fix/restore_user_ui
branch
from
ab56a36
to
45ead9d
Compare
glepnir
reviewed
Jun 1, 2024
lua/dashboard/init.lua
Outdated
| @@ -220,15 +209,34 @@ function db:load_theme(opts) | |||
| end, | |||
| }) | |||
|
|
|||
| api.nvim_create_autocmd('BufEnter', { | |||
| buffer = self.bufnr, | |||
There was a problem hiding this comment.
Oh yeah, merged with the other BufEnter
There was a problem hiding this comment.
Not sure why CI is failing, but let me know what I can do to fix it.
jbarap
force-pushed
the
fix/restore_user_ui
branch
from
45ead9d
to
9565661
Compare
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, #455 restored the user's settings when switching tabs, but was missing the check for the hiding setting being enabled in the first place. This attempts to solve it.
Thanks for bringing it up, and sorry for briefly breaking some configs.