EncoderConfig: introduce GetMaxBFrameCount #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabrain34
force-pushed
the
dab_encode_b_frame_limit
branch
2 times, most recently
from
31ebbe1 to
d50734d
Compare
The default value for B Frame count is 3 but some implementation does not support B frames. Set the value to the max B Frame count supported by the implementation if it exceeds the value. Signed-off-by: Stéphane Cerveau <scerveau@igalia.com>
dabrain34
force-pushed
the
dab_encode_b_frame_limit
branch
from
d50734d to
c2cea14
Compare
|
This patch avoids a GPU hang with RADV driver which does not support B-Frames |
zlatinski
approved these changes
Nov 9, 2024
dabrain34
added a commit
to dabrain34/vk_video_samples
that referenced
this pull request
Nov 27, 2024
To support driver which does not support B Frame, GetMaxBFrameCount has been introduced in nvpro-samples#103 but AV1 was not supported yet.
dabrain34
added a commit
to dabrain34/vk_video_samples
that referenced
this pull request
Nov 27, 2024
To support driver which does not support B Frame, GetMaxBFrameCount has been introduced in nvpro-samples#103 but AV1 was not supported yet. Signed-off-by: Stéphane Cerveau <scerveau@igalia.com>
zlatinski
pushed a commit
that referenced
this pull request
Nov 27, 2024
To support driver which does not support B Frame, GetMaxBFrameCount has been introduced in #103 but AV1 was not supported yet. Signed-off-by: Stéphane Cerveau <scerveau@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value for B Frame count is 3 but some
implementation does not support B Frames.
Set the value to the max B Frame count supported
by the implementation if it exceeds the value.