Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoder: fallback to layered if separate not present #95

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

dabrain34
Copy link
Contributor

@dabrain34 dabrain34 commented Oct 16, 2024

As VK_VIDEO_CAPABILITY_SEPARATE_REFERENCE_IMAGES_BIT_KHR is optional
support, the DPB mode should fallback to layered dpb
if the implementation does not support separate dpb.

@dabrain34 dabrain34 force-pushed the dab_use_layered_dpb_default branch from 715351c to 68ff81f Compare October 16, 2024 10:19
Copy link
Contributor

@zlatinski zlatinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Stephan, The change makes sense, but it is not complete.

As VK_VIDEO_CAPABILITY_SEPARATE_REFERENCE_IMAGES_BIT_KHR is optional
support, the DPB mode should fallback to layered dpb
if the implementation does not support separate dpb.

Signed-off-by: Stéphane Cerveau <scerveau@igalia.com>
@dabrain34 dabrain34 force-pushed the dab_use_layered_dpb_default branch from 68ff81f to 0f6f166 Compare October 25, 2024 14:41
@dabrain34 dabrain34 changed the title EncoderConfig: useDpbArray to true Encoder: fallback to layered if separate not present Oct 25, 2024
Copy link
Contributor

@zlatinski zlatinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Thank you, Stephan!

@zlatinski zlatinski merged commit 1564669 into nvpro-samples:main Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants