-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Judging > Project > Team Member Add/Remove #187
base: main
Are you sure you want to change the base?
Conversation
@kevin-zou is it common/a necessary feature for judges to add/remove team members? |
Visit the preview URL for this PR (updated for commit c7d4d6b): https://nw-admin-portal--pr187-fix-field-display-nc6cngly.web.app (expires Sun, 13 Mar 2022 01:42:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
I believe so! This Admin page is often used for when something goes wrong during project submission and the hacker wants us to do something like change a name, email, title, description, etc. We can do that through Firebase but by putting this functionality in Admin it means that non-dev members can do it as well (and it's also easier to find projects). |
@kevin-zou |
Ah that looks like it's being caused by these lines: admin/pages/Livesite/judging.js Lines 76 to 79 in d773be0
Since we've added project submission to Portal we've also added some fields that are not required. Maybe instead of checking that all fields are populated we can just check that required ones are filled:
I also realize that there's a mismatch between how Projects are saved in Portal vs Admin. A Project in Portal is
This doesn't really match what's happening in admin/pages/Livesite/judging.js Lines 44 to 55 in d773be0
|
Description
"Team Members" field on
Livesite > Judging > Project Edit
would display[Object object]
instead of relevant informationNow, the field shows the names of the team members
(the Kevin Zou's have different IDs, so allowed behavior)
consideration
there's no "discord" field from the applicants records... where should the list of possible team members be pulled? or should there be a separate editor for each team member? (doesn't seem ideal -- non-dev (execs w/ no access to firebase) won't be able to find the hacker's document ID