Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inkind -> inkind #220

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Inkind -> inkind #220

merged 1 commit into from
Nov 17, 2023

Conversation

naijwu
Copy link
Contributor

@naijwu naijwu commented Nov 17, 2023 •
edited
Loading

Description

  • Both default value and selected value (of type In-Kind sponsorship tier) is changed to internally be kept as "inkind", not "Inkind" and "inkind" (more consistent with the all lowercase names of the other sponsorship tiers)

Other considerations

  • Not a necessary or important PR -- we can just ignore the case of the tier name in the front-end where the tiers are parsed

@naijwu naijwu requested a review from meleongg November 17, 2023 07:37
@github-actions GitHub Actions
Copy link

Visit the preview URL for this PR (updated for commit b84b701):

https://nw-admin-portal--pr220-fix-spocos-tier-k6qi2omf.web.app

(expires Fri, 24 Nov 2023 07:40:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

meleongg
meleongg approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@meleongg meleongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once a dev, always a dev

@meleongg meleongg merged commit 4ceee3b into main Nov 17, 2023
5 checks passed
@meleongg meleongg deleted the fix-spocos-tier branch November 17, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meleongg meleongg meleongg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naijwu @meleongg