Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cms query feature #224

Merged
merged 17 commits into from
Dec 13, 2023
Merged

Cms query feature #224

merged 17 commits into from
Dec 13, 2023

Conversation

alvinkam33
Copy link
Contributor

big

Copy link

github-actions bot commented Dec 6, 2023

Visit the preview URL for this PR (updated for commit 9af68b4):

https://nw-admin-portal--pr224-cms-query-0u784rvx.web.app

(expires Wed, 20 Dec 2023 20:26:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

@meleongg
Copy link
Member

meleongg commented Dec 6, 2023

Looks amazing! Tested with a bunch of random queries and they all worked for me.

  • if we can fix linting that would be great, otherwise, we can push this to prod and see if the results we get match the localhost methods we're doing right now to generate queries

@alvinkam33
Copy link
Contributor Author

i fixed the lint issues but idk why the deploy failed

Copy link
Member

@meleongg meleongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meleongg meleongg merged commit f56dd99 into main Dec 13, 2023
5 checks passed
@meleongg meleongg deleted the cms-query branch December 13, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants