diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 155523f7f..b0d69d1a3 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -22,7 +22,7 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4.1.7 - - name: Get Node version from NW.js manifest + - name: Setup Volta uses: volta-cli/action@v4.1.1 - name: Node.js version run: node -v @@ -34,3 +34,24 @@ jobs: run: npm run lint - name: Run tests run: npm run test + cov: + runs-on: ubuntu-22.04 + permissions: + contents: read + pull-requests: write + steps: + - name: Checkout repository + uses: actions/checkout@v4.1.7 + - name: Setup Volta + uses: volta-cli/action@v4.1.1 + - name: Node.js version + run: node -v + - name: npm version + run: npm -v + - name: Install dependencies + run: npm ci + - name: Enable Coverage + run: npm run test:cov + - name: Report Coverage + if: always() + uses: davelosert/vitest-coverage-report-action@v2.4.0 diff --git a/.gitignore b/.gitignore index dec8a7e1d..cbab20330 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,7 @@ .DS_Store .idea +coverage node_modules test/fixture/cache diff --git a/package.json b/package.json index 2342ce80f..2ceeede8f 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,9 @@ "markdown:fix": "markdownlint --fix ./README.md", "docs": "jsdoc -d docs ./README.md ./src/index.js ./src/get.js ./src/run.js ./src/bld.js", "test": "vitest run --coverage", - "demo": "cd test/fixture && node demo.js" + "test:cov": "vitest --coverage.enabled true", + "demo": "cd test/fixture && node demo.js", + "tmp": "vitest --coverage.enabled true" }, "devDependencies": { "@stylistic/eslint-plugin-js": "^2.2.2", diff --git a/src/get/request.js b/src/get/request.js index e399b99e0..bc5768443 100644 --- a/src/get/request.js +++ b/src/get/request.js @@ -23,7 +23,5 @@ export default async function request(url, filePath) { responseType: "stream" }); - response.data.pipe(writeStream); - - // await stream.promises.pipeline(response.data, writeStream); + await stream.promises.pipeline(response.data, writeStream); } diff --git a/test/fixture/ffmpeg-0.83.0-linux-x64.zip b/test/fixture/ffmpeg-0.83.0-linux-x64.zip deleted file mode 100644 index e69de29bb..000000000 diff --git a/vitest.config.js b/vitest.config.js index 709261edf..01ea1ab08 100644 --- a/vitest.config.js +++ b/vitest.config.js @@ -1,12 +1,11 @@ -import { defineConfig -} from 'vitest/config' +import { defineConfig } from 'vitest/config' -export default defineConfig -({ - test: { - coverage: { - provider: 'v8', - reporter: ['text'], - }, - }, -}) \ No newline at end of file +export default defineConfig({ + test: { + coverage: { + provider: 'v8', + reporter: ['json-summary'], + reportOnFailure: true, + } + } +});