Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS nwjs Framework image not found #443

Closed
cry0m1 opened this issue Apr 20, 2017 · 9 comments
Closed

MacOS nwjs Framework image not found #443

cry0m1 opened this issue Apr 20, 2017 · 9 comments

Comments

@cry0m1
Copy link

cry0m1 commented Apr 20, 2017

Hi all,
MacOS 10.12.4 Sierra
nw js 0.22.0 sdk

I did download/unpack with nw-builder https://github.com/nwjs-community/nw-builder.

$ /0.22.0-sdk/osx64/nwjs.app/Contents/MacOS/nwjs

dlopen /0.22.0-sdk/osx64/nwjs.app/Contents/MacOS/../Versions/58.0.3029.81/nwjs Framework.framework/nwjs Framework: 
dlopen(/0.22.0-sdk/osx64/nwjs.app/Contents/MacOS/../Versions/58.0.3029.81/nwjs Framework.framework/nwjs Framework, 257): 
image not found
Abort trap: 6

details in nwjs/nw.js#5863

@tsnelson1
Copy link

tsnelson1 commented May 1, 2017

I have investigated this issue as I was having the same issue, and here is what I have found to be the main issue. Extracting of the NWJS SDK (and this is exclusively with a change in v0.22.0 with the Chromium 58 migration), creates symbolic links that are invalid once nw-builder builds up the cache.

Here is where I found the problem (I hope this pasted link works, as I don't typically comment):
https://github.com/bower/decompress-zip/blob/master/lib/extractors.js#LC109
return symlink(path.resolve(parent, linkTo), destination)

This creates a symbolic link to the absolute path, which subsequently gets its underlying path renamed, and thus breaks. Changing this line to the following fixes the issue for Mac OSX so I can make it work, however, I have no idea what other ramifications it could cause otherwise that could be unintentional.
return symlink(linkTo, destination)

@TatriX
Copy link

TatriX commented May 3, 2017

I have the same issue when I build the package from linux and then transfer it to a mac.

@cry0m1
Copy link
Author

cry0m1 commented May 3, 2017

@TatriX seems this package have no longer support, I moved to https://github.com/evshiron/nwjs-builder-phoenix, they have fixed this issue quickly. @tsnelson1 you are right.

@rogerwang
Copy link

@adam-lynch @DblK are you still maintaining this project? If yes, is there any plan on this issue? CC #444 #445

@adam-lynch
Copy link
Contributor

Working on this

@adam-lynch
Copy link
Contributor

Sorry about that. I've just published 3.2.1 which should fix this. Let me know if there is any problem with it.

@adam-lynch
Copy link
Contributor

I should have said that you'll need to delete your cache directory. The bug resulted in something broken being cached. Thanks

@axtro
Copy link

axtro commented Jul 18, 2017

Version 3.4.1 is still failing.
@tsnelson1 's solution fixes the problem. It's a problem with the decompress-zip library.

@wfcardonag
Copy link

wfcardonag commented Jul 28, 2017

@axtro @tsnelson1 Hi, maybe you can say me where is located the file of descompress-zip to make the change, thanks!

IharKrasnik added a commit to goLance-LLC/decompress-zip that referenced this issue Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants