Don't overwrite all options previously specified when manifest is found (assign re-defined only) #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,11 +43,15 @@ async function nwbuild(options) { | |||
|
|
|||
| try { | |||
| // Parse options | |||
| options = await util.parse(options, manifest); | |||
There was a problem hiding this comment.
I remember why I did this. If options.srcDir or options.glob is undefined, then getNodeManifest function will throw an error. This is why the parse function is called twice. If there's a better way to go about this, I'm all ears
There was a problem hiding this comment.
@Black-Platypus ping
Also nothing should be overwritten. If an option is undefined, the default value is used for it. If an option is being overwritten, then its probably an error in the parse function. |
ayushmanchhabra
force-pushed
the
keep-options
branch
from
63aa95b
to
eec849e
Compare
…nd (assign re-defined only)
ayushmanchhabra
force-pushed
the
keep-options
branch
from
eec849e
to
5d59701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep anything the user specified in the
optionsobject and only overwrite things found in any manifest (package.json) found.manifest.apptooptions.appmanifesttooptionsoptions.appFixes: #1261