Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osx): set NSHumanReadableCopyright property #904

Merged
merged 6 commits into from
Jul 25, 2023
Merged

Conversation

ayushmanchhabra
Copy link
Collaborator

@ayushmanchhabra ayushmanchhabra commented Jul 19, 2023

Fixes: #897

Description

  • Correctly set NSHumanReadableCopyright property.

Testing Steps

  • Fork repo
  • Checkout dev-897 branch
  • npm install dependencies
  • npm run test:mod to build demo app
  • Go to test/fixture/out/demo.app/Resources/en.lproj/InfoPlist.strings
  • Verify that NSHumanReadableCopyright = "Copyright 2023 NW.js Utils. All Rights Reserved."; exists in file
  • Go to file explorer/Finder, right click and get app details demo.app
  • Verify that the copyright is Copyright 2023 NW.js Utils. All Rights Reserved.

cc @rocketVibes

@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review July 19, 2023 12:20
@ayushmanchhabra
Copy link
Collaborator Author

review_app_ss
Reviewed in Discord

@ayushmanchhabra ayushmanchhabra merged commit 03fda3f into main Jul 25, 2023
3 checks passed
@ayushmanchhabra ayushmanchhabra deleted the dev-897 branch July 25, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[osx64] Copyright is not configurable - always set to default nwjs
1 participant