Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More update on Settings help links #40

Closed
wants to merge 3 commits into from

Conversation

DelazJ
Copy link

@DelazJ DelazJ commented Nov 20, 2023

Hi Nyall,

  • Instead of using the user visible section title that may change in the future (either in the GUI or because we use a different type of titling in the docs) I suggest we rely on the sections anchors that almost never change.
  • While at it, instead of customizing links for only the tabs that do not belong to the Options ui file, I suggest we use direct links for the other tabs too. Not sure if the "if .. else if" style is the more appropriate.
  • Last, I add a help link for the User profile tab also (but still remains the last screenshot at Tweaking user profile selector dialog and settings qgis/QGIS#53569 (comment))

@DelazJ
Copy link
Author

DelazJ commented Nov 21, 2023

@nyalldawson Just to get sure you noticed this one, for qgis#55291

@nyalldawson
Copy link
Owner

This looks better than my approach! 😁 Could you open this against the main repo and I'll approve?

@DelazJ DelazJ closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants