Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added make uninstall #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Added make uninstall #32

wants to merge 1 commit into from

Conversation

alquerci
Copy link
Collaborator

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Related tickets
License GNU GPLv3
  • Ensure that works

@alquerci alquerci added this to the 1.1 milestone Aug 25, 2014
@alquerci alquerci modified the milestones: 1.1, 1.2 Sep 4, 2014
@nylen
Copy link
Owner

nylen commented Sep 17, 2014

This is a good feature. A few questions:

  • Shouldn't we remove directories as well? (/usr/share/doc/cyg-apt/, /usr/lib/python2.7/site-packages/cygapt/, etc.)
  • Shouldn't we remove egg-info files like /usr/lib/python2.7/site-packages/cygapt-1.1.0rc1_91.ge480502.dirty-py2.7.egg-info?
  • Any problem with adding -v to rm options to display progress?

@alquerci
Copy link
Collaborator Author

  • Directories should be keep because we don't know what the user do with theses.
  • For egg-info files I don't know maybe yes (about old one).
  • rm -v nice idea

We need to learn about what we are allow to do on make uninstall.

We currently work on a Makefile that follow GNU coding standards (ref) co this implementation becomes out of date.

@alquerci
Copy link
Collaborator Author

Closing in favor of #66

@alquerci alquerci closed this Sep 27, 2014
@alquerci alquerci deleted the add/make_uninstall branch September 27, 2014 15:15
@alquerci alquerci restored the add/make_uninstall branch April 11, 2015 12:29
@alquerci
Copy link
Collaborator Author

Reopen this since #69 has been planned for the version 2.0.

@alquerci alquerci reopened this Apr 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
1.2 (master)
Development

Successfully merging this pull request may close these issues.
2 participants
@alquerci @nylen