Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed installation process by following GNU coding standards #66

Closed
wants to merge 60 commits into from

Conversation

alquerci
Copy link
Collaborator

Q A
Bug fix? yes (some unexpected make behaviours)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Related tickets
License GNU GPLv3

In order to come as close as possible to the GNU coding standards.

The python library of this package is private so it does not install under the standard python site-package but on $(DESTDIR)$(pkglibdir).

  • added a check for $(DESTDIR) feature on the distcheck target
  • update the doc
  • clean up commit history
  • optionals:
    • maybe added a small configure script ref
    • added uninstall feature

@alquerci alquerci added this to the 1.1 milestone Sep 27, 2014
@alquerci alquerci added the Bug label Sep 27, 2014
@alquerci alquerci mentioned this pull request Sep 27, 2014
1 task
@alquerci alquerci force-pushed the feature/gnu_makefile branch 15 times, most recently from aa78939 to 19aa0a2 Compare October 3, 2014 09:46
@alquerci alquerci force-pushed the feature/gnu_makefile branch 5 times, most recently from d6187da to 12a6b7d Compare October 6, 2014 15:05
@alquerci alquerci force-pushed the master branch 2 times, most recently from 635047d to 4be517a Compare October 7, 2014 19:59
alquerci added a commit to alquerci/cyg-apt that referenced this pull request Oct 12, 2014
… standards (alquerci)

This PR was squashed before being merged into the 1.1-dev branch (closes nylen#66).

Discussion
----------

| Q               | A
| --------------- | ---
| Bug fix?        | yes (some unexpected make behaviours)
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Tests pass?     | yes
| Related tickets |
| License         | GNU GPLv3

In order to come as close as possible to the [GNU coding standards][2].

The python library of this package is private so it does not install under the standard python `site-package` but on [`$(DESTDIR)$(pkglibdir)`][1].

- [x] added a check for `$(DESTDIR)` feature on the `distcheck` target
- [ ] update the doc
- [ ] clean up commit history
- [ ] optionals:
  - [x] maybe added a small configure script [ref][0]
  - [ ] added uninstall feature

[0]: https://github.com/nylen/cyg-apt/blob/431821aa8a3f2d5317424e7eebfbf39cc60eb760/TODO#L9
[1]: https://github.com/alquerci/cyg-apt/blob/e10d29636f227b45fe2d46b995324152034c648a/bootstrap.mk#L112
[2]: https://www.gnu.org/prep/standards/html_node/Makefile-Conventions.html#Makefile-Conventions

Commits
-------

80ad1b7 [WIP] Fixed installation process by following GNU coding standards
@alquerci
Copy link
Collaborator Author

Closing in favour of #69

@alquerci alquerci closed this Oct 22, 2014
@alquerci alquerci deleted the feature/gnu_makefile branch October 22, 2014 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant