Skip to content

Commit

Permalink
Use expect in geodata test to give error message on failure (#5314)
Browse files Browse the repository at this point in the history
* Use expect in geodata test to give error message on failure

I keep hitting this error on CI, from what I think is network hickup.
But it's hard to tell form the log since the error is swallowed.

Explicitly unwrap the result so we get a more detailed error output

* Add nym-node-status-api to ci-build
  • Loading branch information
octol authored Jan 8, 2025
1 parent f3d8aba commit 9b02de3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/ci-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,16 @@ on:
- 'gateway/**'
- 'integrations/**'
- 'mixnode/**'
- 'sdk/rust/**'
- 'sdk/lib/**'
- 'service-providers/**'
- 'nym-network-monitor/**'
- 'nym-api/**'
- 'nym-data-observatory/**'
- 'nym-network-monitor/**'
- 'nym-node/**'
- 'nym-node-status-api/**'
- 'nym-outfox/**'
- 'nym-data-observatory/**'
- 'nym-validator-rewarder/**'
- 'sdk/lib/**'
- 'sdk/rust/**'
- 'service-providers/**'
- 'tools/**'
- 'wasm/**'
- 'Cargo.toml'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,10 @@ mod api_regression {
let location_result = client.locate_ip(my_ip).await;
assert!(location_result.is_ok(), "Did ipinfo response change?");

assert!(
client.check_remaining_bandwidth().await.is_ok(),
"Failed to check remaining bandwidth?"
);
client
.check_remaining_bandwidth()
.await
.expect("Failed to check remaining bandwidth?");

// when serialized, these fields should be present because they're exposed over API
let location_result = location_result.unwrap();
Expand Down

0 comments on commit 9b02de3

Please sign in to comment.