From 9b02de3e758ec149c0c947e611a735f2440a9e48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jon=20H=C3=A4ggblad?= Date: Wed, 8 Jan 2025 10:56:26 +0100 Subject: [PATCH] Use expect in geodata test to give error message on failure (#5314) * Use expect in geodata test to give error message on failure I keep hitting this error on CI, from what I think is network hickup. But it's hard to tell form the log since the error is swallowed. Explicitly unwrap the result so we get a more detailed error output * Add nym-node-status-api to ci-build --- .github/workflows/ci-build.yml | 11 ++++++----- .../nym-node-status-api/src/monitor/geodata.rs | 8 ++++---- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index d07f7edcbd..e994671b5b 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -9,15 +9,16 @@ on: - 'gateway/**' - 'integrations/**' - 'mixnode/**' - - 'sdk/rust/**' - - 'sdk/lib/**' - - 'service-providers/**' - - 'nym-network-monitor/**' - 'nym-api/**' + - 'nym-data-observatory/**' + - 'nym-network-monitor/**' - 'nym-node/**' + - 'nym-node-status-api/**' - 'nym-outfox/**' - - 'nym-data-observatory/**' - 'nym-validator-rewarder/**' + - 'sdk/lib/**' + - 'sdk/rust/**' + - 'service-providers/**' - 'tools/**' - 'wasm/**' - 'Cargo.toml' diff --git a/nym-node-status-api/nym-node-status-api/src/monitor/geodata.rs b/nym-node-status-api/nym-node-status-api/src/monitor/geodata.rs index 8841d3f505..9bafc2b4ad 100644 --- a/nym-node-status-api/nym-node-status-api/src/monitor/geodata.rs +++ b/nym-node-status-api/nym-node-status-api/src/monitor/geodata.rs @@ -174,10 +174,10 @@ mod api_regression { let location_result = client.locate_ip(my_ip).await; assert!(location_result.is_ok(), "Did ipinfo response change?"); - assert!( - client.check_remaining_bandwidth().await.is_ok(), - "Failed to check remaining bandwidth?" - ); + client + .check_remaining_bandwidth() + .await + .expect("Failed to check remaining bandwidth?"); // when serialized, these fields should be present because they're exposed over API let location_result = location_result.unwrap();