Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update admonish version && Fix formatting #3976

Merged
merged 3 commits into from
Oct 16, 2023
Merged

[DOCS] Update admonish version && Fix formatting #3976

merged 3 commits into from
Oct 16, 2023

Conversation

serinko
Copy link
Contributor

@serinko serinko commented Oct 10, 2023

Description

CD/CI returns error on admonish plugin, This shall fix it.

@serinko serinko requested a review from mfahampshire as a code owner October 10, 2023 21:24
@serinko serinko self-assigned this Oct 10, 2023
@tommyv1987 tommyv1987 self-requested a review October 16, 2023 11:09
tommyv1987
tommyv1987 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tommyv1987 tommyv1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good, this should also fix - #3993

@tommyv1987 tommyv1987 merged commit dd5d13c into develop Oct 16, 2023
1 of 2 checks passed
@tommyv1987 tommyv1987 deleted the documentation/updates branch October 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyv1987 tommyv1987 tommyv1987 approved these changes

@mfahampshire mfahampshire Awaiting requested review from mfahampshire mfahampshire is a code owner

Assignees

@serinko serinko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serinko @tommyv1987