Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max/openapi docs #5219

Merged
merged 42 commits into from
Dec 11, 2024
Merged

Max/openapi docs #5219

merged 42 commits into from
Dec 11, 2024

Conversation

mfahampshire
Copy link
Contributor

@mfahampshire mfahampshire commented Dec 5, 2024 •
edited
Loading

This now includes:

  • tweaks to zknyms
  • autodoc script now builds binaries against master, regardless of what branch it is being run on. This is so we have latest build info for node operator docs w/out having to rely on merging to and building from master
  • openapi docs

NOTICE: REBASE ONCE RELEASE DOCS ARE OUT THEN DEPLOY

This change is Reviewable

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:14pm
nym-next-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 4:14pm

mfahampshire and others added 2 commits December 5, 2024 23:23
@mfahampshire
revert credit to ticket & ticketbook and actually get all the instanc…
1e954fd 
…es to replace
@mfahampshire
Max/zknym doc tweak (#5223)
6d5681a 
* revert credit to ticket & ticketbook

* revert credit to ticket & ticketbook and actually get all the instances to replace
@mfahampshire mfahampshire mentioned this pull request Dec 9, 2024
Closed
serinko
serinko requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@serinko serinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a look on the png change here before merging.

documentation/docs/components/outputs/command-outputs/nym-node-node-details.md Show resolved Hide resolved
documentation/docs/images/archive/images/gateway-bonded.png Outdated Show resolved Hide resolved
documentation/docs/images/operators/wallet-screenshots/node_settings.png Outdated Show resolved Hide resolved
@mfahampshire
Copy link
Contributor Author

mfahampshire commented Dec 10, 2024 •
edited
Loading

NOTICE: REBASE ONCE RELEASE DOCS ARE OUT THEN DEPLOY Doesnt look necessary now

serinko
serinko approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@serinko serinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on preview as well, beautiful. I would consider to add the favicons though.

@mfahampshire mfahampshire merged commit a336893 into develop Dec 11, 2024
8 of 10 checks passed
@mfahampshire mfahampshire deleted the max/openapi-docs branch December 11, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serinko serinko serinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfahampshire @serinko