Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken same page links #64

Open
wlla opened this issue Feb 8, 2017 · 3 comments
Open

Broken same page links #64

wlla opened this issue Feb 8, 2017 · 3 comments
Assignees
@bertspaan @wlla
Labels
enhancement

Comments

@wlla
Copy link
Contributor

wlla commented Feb 8, 2017

4 broken same page links are flagged in all pages: H1 link and 3 main nav links.

QA ISSUE
@wlla wlla added the shipping label Feb 8, 2017
@bertspaan
Copy link
Collaborator

Links seem to be just fine: <a class="selected" href="#/list">List</a>, not broken at all.

@wlla Can I close this?

@bertspaan
Copy link
Collaborator

@seanredmond: these are not real links, the # they does not exists, but JS handles the click. What should I do?

@wlla
Copy link
Contributor Author

wlla commented Feb 13, 2017

This was flagged in the WAVE tool and per above comment are to be considered in larger discussions.

Since the page is functional for browsers and various AT, this ticket has been moved to enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertspaan bertspaan

@wlla wlla

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bertspaan @wlla