Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map browse keyboard nav bug #86

Open
wlla opened this issue Mar 2, 2017 · 3 comments
Open

Map browse keyboard nav bug #86

wlla opened this issue Mar 2, 2017 · 3 comments
Assignees

Comments

@wlla
Copy link
Contributor

wlla commented Mar 2, 2017

On the map page, if you tab the arrow keys stop working correctly. For example:

  1. Load the page
  2. Hit any arrow key
  3. The target appears and map scrolls under the target
  • vs. -
  1. Load the page
  2. Hit tab
  3. The "+" button get the focus
  4. Hit any arrow key
  5. The target appears, but you can't scroll the map

https://docs.google.com/a/nypl.org/document/d/1xHhy6qQfZhWq-KktV__cWSfCnPQtTe0fhapS_Ka2HWs/edit?disco=AAAAA8gQDsg

@bertspaan
Copy link
Collaborator

This is not a bug - you can only use the arrow keys (and the +/- buttons to zoom) if the map itself is focused.

@bertspaan
Copy link
Collaborator

For example, if the sidebar (or an item in the sidebar) is focused, you can use the arrow keys to scroll up and down in the sidebar.

We could argue that if the map or any other element in the map pane is focused, the arrow keys should control the map.

@seanredmond
Copy link

I think you're right. Unless there is something else the arrow keys naturally do on the page (I don't think there is) let pressing an arrow key focus the map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants