Skip to content

Commit

Permalink
added themissing '&' (#255)
Browse files Browse the repository at this point in the history
  • Loading branch information
bonomite authored Mar 13, 2023
1 parent a91c85d commit 8751c01
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const onCtaClick = () => {
})
// link here ("?utm_source=....." is added in the backend, so we don't need to add the "?" here before "utm_medium".)
window.open(
`${bannerData.buttonLink}utm_medium=article-inline-bottom`,
`${bannerData.buttonLink}&utm_medium=article-inline-bottom`,
'_blank'
)
emit('donate-click')
Expand Down
5 changes: 4 additions & 1 deletion components/marketing-banners/ArticleDonationMarketingCTA.vue
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ const onCtaClick = () => {
event_label: `${buttonText.value} button`,
})
// link here ("?utm_source=....." is added in the backend, so we don't need to add the "?" here before "utm_medium".)
window.open(`${bannerData.buttonLink}utm_medium=article-inline-top`, '_blank')
window.open(
`${bannerData.buttonLink}&utm_medium=article-inline-top`,
'_blank'
)
emit('donate-click')
}
</script>
Expand Down
2 changes: 1 addition & 1 deletion components/marketing-banners/MarketingModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const onCtaClick = () => {
})
// link here ("?utm_source=....." is added in the backend, so we don't need to add the "?" here before "utm_medium".)
window.open(
`${bannerData.buttonLink}utm_medium=product-marketing-banner`,
`${bannerData.buttonLink}&utm_medium=product-marketing-banner`,
'_blank'
)
displayModal.value = false
Expand Down

0 comments on commit 8751c01

Please sign in to comment.