From 8751c011906980dcb672efc4a08b94d552d3acca Mon Sep 17 00:00:00 2001 From: Bono <13803343+bonomite@users.noreply.github.com> Date: Mon, 13 Mar 2023 15:11:43 -0400 Subject: [PATCH] added themissing '&' (#255) --- .../marketing-banners/ArticleDonationMarketingBottomCTA.vue | 2 +- components/marketing-banners/ArticleDonationMarketingCTA.vue | 5 ++++- components/marketing-banners/MarketingModal.vue | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/components/marketing-banners/ArticleDonationMarketingBottomCTA.vue b/components/marketing-banners/ArticleDonationMarketingBottomCTA.vue index 85d86514..1c86cbdd 100644 --- a/components/marketing-banners/ArticleDonationMarketingBottomCTA.vue +++ b/components/marketing-banners/ArticleDonationMarketingBottomCTA.vue @@ -29,7 +29,7 @@ const onCtaClick = () => { }) // link here ("?utm_source=....." is added in the backend, so we don't need to add the "?" here before "utm_medium".) window.open( - `${bannerData.buttonLink}utm_medium=article-inline-bottom`, + `${bannerData.buttonLink}&utm_medium=article-inline-bottom`, '_blank' ) emit('donate-click') diff --git a/components/marketing-banners/ArticleDonationMarketingCTA.vue b/components/marketing-banners/ArticleDonationMarketingCTA.vue index d7990450..9534a42d 100644 --- a/components/marketing-banners/ArticleDonationMarketingCTA.vue +++ b/components/marketing-banners/ArticleDonationMarketingCTA.vue @@ -27,7 +27,10 @@ const onCtaClick = () => { event_label: `${buttonText.value} button`, }) // link here ("?utm_source=....." is added in the backend, so we don't need to add the "?" here before "utm_medium".) - window.open(`${bannerData.buttonLink}utm_medium=article-inline-top`, '_blank') + window.open( + `${bannerData.buttonLink}&utm_medium=article-inline-top`, + '_blank' + ) emit('donate-click') } diff --git a/components/marketing-banners/MarketingModal.vue b/components/marketing-banners/MarketingModal.vue index 69c05f60..0256acb7 100644 --- a/components/marketing-banners/MarketingModal.vue +++ b/components/marketing-banners/MarketingModal.vue @@ -44,7 +44,7 @@ const onCtaClick = () => { }) // link here ("?utm_source=....." is added in the backend, so we don't need to add the "?" here before "utm_medium".) window.open( - `${bannerData.buttonLink}utm_medium=product-marketing-banner`, + `${bannerData.buttonLink}&utm_medium=product-marketing-banner`, '_blank' ) displayModal.value = false