Day of year formatting now parses elapsed time #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is was an oversight of the code and testing. Fix #248
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "hifitime" | |||
| version = "3.8.3" | |||
| version = "3.8.4" | |||
There was a problem hiding this comment.
Auto-formatting of the TOML and version bump.
| @@ -309,7 +309,14 @@ impl Format { | |||
| }; | |||
|
|
|||
| let epoch = match day_of_year { | |||
| Some(days) => Epoch::from_day_of_year(decomposed[0], days, ts), | |||
| Some(days) => { | |||
There was a problem hiding this comment.
This was the oversight.
| @@ -522,3 +529,10 @@ fn epoch_format_from_str() { | |||
| let fmt = Format::from_str("%a, %d %b %Y %H:%M:%S").unwrap(); | |||
| assert_eq!(fmt, crate::efmt::consts::RFC2822); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn gh_248_regression() { | |||
There was a problem hiding this comment.
Added related regression test.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 80.62% 80.68% +0.06%
==========================================
Files 15 15
Lines 3736 3748 +12
==========================================
+ Hits 3012 3024 +12
Misses 724 724
☔ View full report in Codecov by Sentry. |
ChristopherRabotin
deleted the
248-epochfrom_format_str-does-not-set-hours-minutes-and-seconds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is was an oversight of the code and testing.
Fix #248