Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS modules process class names twice #22

Closed
viktor-yakubiv opened this issue Dec 13, 2019 · 3 comments
Closed

CSS modules process class names twice #22

viktor-yakubiv opened this issue Dec 13, 2019 · 3 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@viktor-yakubiv
Copy link
Member

We need to load CSS files from @design/library globally, i.e. without CSS modules. Unfortunately, PostCSS doesn't support something like this:

:global {
	import url('@oacore/design/lib/index.css')
}

Therefore we need to do it on WebPack level. But there was a problem when @oacore/design was symlinked because regular expression does not match.

Reported by @Joozty in #19

@viktor-yakubiv viktor-yakubiv added the 🐛 bug Something isn't working label Dec 13, 2019
@viktor-yakubiv viktor-yakubiv self-assigned this Dec 13, 2019
@viktor-yakubiv
Copy link
Member Author

@Joozty would this config solve the problem?

@Joozty
Copy link
Member

Joozty commented Dec 13, 2019

I think we are fine with what we have now.

@viktor-yakubiv
Copy link
Member Author

Please, reopen if this is not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants