Skip to content

Commit

Permalink
oak: remove resolved TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
200sc committed Sep 20, 2021
1 parent 8e41b18 commit 7139cc7
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion collision/label.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package collision
const (
// NilLabel is used internally for spaces that are otherwise not
// given labels.
// TODO V3: why is this exported
NilLabel Label = -1
)

Expand Down
2 changes: 0 additions & 2 deletions config.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ func ReaderConfig(r io.Reader) ConfigOption {
}

func (c Config) overwriteFrom(c2 Config) Config {
// TODO: is this the right place for these configuration pieces?
// TODO: is there other configuration that should go here?
if c2.Assets.AudioPath != "" {
c.Assets.AudioPath = c2.Assets.AudioPath
}
Expand Down
2 changes: 0 additions & 2 deletions dlog/default.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ func NewLogger() Logger {
// containing the logged data separated by spaces,
// prepended with file and line information.
// It only includes logs which pass the current filters.
// Todo: use io.Multiwriter to simplify the writing to
// both logfiles and stdout
func (l *logger) dLog(level Level, in ...interface{}) {
//(pc uintptr, file string, line int, ok bool)
_, f, line, ok := runtime.Caller(2)
Expand Down
2 changes: 0 additions & 2 deletions mouse/mouse.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ const (
ButtonNone = mouse.ButtonNone
)

//TODO V3: should event names be strings?

// GetEventName returns a string event name given some mobile/mouse information
func GetEventName(d mouse.Direction, b mouse.Button) string {
switch d {
Expand Down
2 changes: 1 addition & 1 deletion viewport_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
)

func sleep() {
// TODO V3: test how far we can bring this down and get consistent results
// TODO: test how far we can bring this down and get consistent results
time.Sleep(300 * time.Millisecond)
}

Expand Down

0 comments on commit 7139cc7

Please sign in to comment.