Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required ReadTheDocs configuration #294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Apr 5, 2024

Should fix broken RTD doc builds. Needed because of https://blog.readthedocs.com/migrate-configuration-v2/

@rpiazza

@clenk
Copy link
Contributor Author

clenk commented Apr 5, 2024

Failing due to

AttributeError: module 'lxml.etree' has no attribute '_ElementStringResult'

@clenk
Copy link
Contributor Author

clenk commented Apr 5, 2024

More info on failure:
stixmarx uses that etree property here: https://github.com/mitre/stixmarx/blob/4f906eb15af431c12c36c8683f9bcd60d39c364e/stixmarx/xml.py#L59
But it was removed in this commit: lxml/lxml@eba7934

We could pin lxml to <5.1.1 here or fix that line in stixmarx and make a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant