Context fragment of contained single entity #2009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
reviewed
Oct 3, 2024
odata-protocol/10 Context URL.md
Outdated
| @@ -103,6 +103,7 @@ the type of the returned entity collection. | |||
| Context URL template: | |||
|
|
|||
| {context-url}#{entity-set}/$entity | |||
| {context-url}#{single-navprop} | |||
There was a problem hiding this comment.
In line 25 above we define
{entity-set}is the name of an entity set or path to a containment navigation property
Please call this {single-entity}, add a definition for it, use it also for singletons, and reduce the definition of {entity-set} to collection-valued nav props.
ralfhandl
requested changes
Oct 10, 2024
There was a problem hiding this comment.
I really think that the text will be easier if we define
{entity-set}is the name of an entity set or path to a collection-valued containment navigation property{single-entity}is the name of a singleton or path to a single-valued containment navigation property
and then use these definitions in the text below
odata-protocol/10 Context URL.md
Outdated
| @@ -103,6 +103,7 @@ the type of the returned entity collection. | |||
| Context URL template: | |||
|
|
|||
| {context-url}#{entity-set}/$entity | |||
| {context-url}#{single-navprop} | |||
There was a problem hiding this comment.
Suggested change
| {context-url}#{single-navprop} | |
| {context-url}#{single-entity} |
Use this also for singletons
ralfhandl
requested changes
Oct 10, 2024
ralfhandl
previously approved these changes
Oct 10, 2024
HeikoTheissen
commented
Oct 17, 2024
Comment on lines
+264
to
266
| If the response is not a subset of a | ||
| single entity set, the `{select-list}` is instead appended to the | ||
| `{type-name}` of the returned entity. |
There was a problem hiding this comment.
This case cannot occur, because the response in this section is always one entity, not a (sub)set.
navigation properties
2000/single-navprop-context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2000