Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

negative pLen #4

Open
bennetyee opened this issue Mar 22, 2019 · 0 comments
Open

negative pLen #4

bennetyee opened this issue Mar 22, 2019 · 0 comments

Comments

@bennetyee
Copy link
Member

go-common/sivaessha2/symmetric.go

Line 111 in 02817f4

aadLen, pLen := len(additionalData), len(ciphertext)-TagSize

negative pLen when len(cipherText) < TagSize is checked by writeLenVec which is a bit weird since it's usually nice to check nearer where the possibly bad value is computed.

a comment on L170 on why aadLen < 0 check is not necessary (and remove the commented out check code) would be nice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bennetyee