Defer importing polyfills (esp. node-fetch) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Parcel client cannot be bundled with ViteJS since it fails to pre-bundle a package with dependency to node-specific module. Parcel client has direct dependency to node-fetch, which in turn depends on a bunch of node-specific features, to polyfill
fetch
.Solution
polyfill.ts
as the blocker to use ky-universal directly.My Svelte app works fine with these changes and setting
vite.optimizeDeps.exclude
to['node-fetch']
. I suppose Vue apps may be the same.It passes all unit tests that passes at
main
on my end, but not really confident if this works in node as well.