docs: Adds section for funding the contract without receive() #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-sapphire-paratime ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CedarMist
approved these changes
May 30, 2024
There was a problem hiding this comment.
Seems like a good update.
One small improvement I'd suggest is making the differences a bullet-point list at the top of 'Sapphire vs Ethereum', then going into further detail.
It could be noted that transactions are finalized after being mined, with no additional finality window required (so 6 second finality).
Sapphire is a fast, cheap & private Ethereum :)
|
@kostko Can you please check https://github.com/oasisprotocol/sapphire-paratime/pull/318/files#diff-5ba983da752e82d1bbf6d42cc9ea14f59e058ca16e681afac403a48bdb123512R143-R156 for any misinformation I may have written. |
kostko
approved these changes
May 30, 2024
matevz
force-pushed
the
matevz/docs/fund-contract-without-receive
branch
3 times, most recently
from
55c4148 to
d7bde60
Compare
matevz
force-pushed
the
matevz/docs/fund-contract-without-receive
branch
from
d7bde60 to
996ed46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREVIEW