Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Cleanup repository #1

Open
hohwille opened this issue Jan 12, 2018 · 0 comments
Open

Cleanup repository #1

hohwille opened this issue Jan 12, 2018 · 0 comments

Comments

@hohwille
Copy link
Member

Great to see that you did a OASP4J demo in Kotlin and thanks for that. I am also looking at Kotlin with increasing interest.

However, I wanted to give some feedback for improvements:

  • you should have a .gitignore to prevent comitting generated files. See https://github.com/oasp/oasp4j/blob/develop/.gitignore
  • as you had not .gitignore in place you comitted and pushed a lot of generate stuff like .settings and especially target folders what is heavily discouraged and should be deleted.

Here is an incomplete list of such files and folders:

BTW: The recommended way is to start such repositories on https://github.com/oasp-forge/ instead of https://github.com/oasp/. oasp-forge is for experimental stuff while oasp should contain "production-ready" projects (whoever created this repo [for you]). My intention is not to blame, just to let know...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant