Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Open reviews in code #484

Open
1 of 2 tasks
sroeger opened this issue Sep 1, 2016 · 2 comments
Open
1 of 2 tasks

Open reviews in code #484

sroeger opened this issue Sep 1, 2016 · 2 comments

Comments

@sroeger
Copy link

sroeger commented Sep 1, 2016

This issue summarizes java tasks from the code. Actually there are two reviews left:

REVIEW arturk88 (hohwille) we need to find another way to stream the blob without loading into heap.

and

REVIEW may-bee (hohwille) We have a centralized and custom-configured object mapper as spring bean. IMHO we should inject that instance here.

In order to clean up the code those Java Tasks will be removed from the code.

@hohwille
Copy link
Member

hohwille commented Dec 5, 2017

I checked the first issue because restaurant is a dead-end that will be deleted soon.
The second one could either be solved by just removing the comment (there are only 2 properties mapped so actually no issue) or by just injecting the object mapper.

@hohwille
Copy link
Member

Injecting the mapper would create an unnecessary dependency from security to rest. Why doing that and also getting in danger of undersired side-effects?
Also the question is if that class may also be deleted in the future...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants