Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Invalid Homepage URLs of maven central deployments #505

Open
maybeec opened this issue Oct 18, 2016 · 6 comments
Open

Invalid Homepage URLs of maven central deployments #505

maybeec opened this issue Oct 18, 2016 · 6 comments

Comments

@maybeec
Copy link
Member

maybeec commented Oct 18, 2016

The URL shown at the maven central deployment for each module seems to be wrong (does not exist) and should be corrected in future builds:

capture

@maybeec maybeec added this to the oasp:2.1.2 milestone Oct 18, 2016
@hohwille
Copy link
Member

hohwille commented Nov 2, 2016

What is expected?
https://github.com/oasp/oasp4j/tree/develop/modules/jpa

If so someone needs to provide a PR where all pom.xml files get an added url tag instead of relying on the maven inheritance defaults.

Is this really a blocker for 2.1.2? We are IMHO 2 month overdue. If you want to have this in 2.1.2 then provide a PR asap otherwise I will postpone this to a further release.

@hohwille
Copy link
Member

hohwille commented Nov 2, 2016

If we would have a link to the recent maven site everything would be correct:
http://oasp.github.io/oasp4j/2.1.0/maven/oasp4j-modules/oasp4j-jpa/index.html

But therefore we would need some kind of redirect from http://oasp.github.io/oasp4j/latest/<X> to http://oasp.github.io/oasp4j/x.y.z/<X>.
Or we manually put the latest version in there (or we do not keep old versions what is not a really good idea). If we can host this manually it would be easy but with plain HTML and JS we would need to write some magic if it is hosted by github. Maybe we can put something with some smart rewrite rules in http://oasp.io

@hohwille hohwille modified the milestones: backlog-asap, oasp:2.1.2 Nov 2, 2016
@hohwille
Copy link
Member

hohwille commented Dec 5, 2017

IMHO maven is somehow stupid here. It does not considere the physical module paths but uses artifactIds instead as default. As we are DRY we use short names which is IMHO fine.
Therefore we need to create a workaround to override the URL in our modules instead of relying on the maven magic that does not work here.
Maybe in parent POM we can also define an URL like https://github.com/oasp/oasp4j/tree/develop/modules/${module.name}. We can do the same for SCM and other such things.
Then all we need to do is to add the module.name property to each of the child modules.
Is someone able to create a PR for this?

@maybeec
Copy link
Member Author

maybeec commented Dec 5, 2017

Might be an idea. Or we simply provide redirects in a generic way for github pages. Do GitHub pages support url rewriting?

@hohwille
Copy link
Member

hohwille commented Dec 8, 2017

The links do not go to our gh-pages (oap.github.io) but to the regular github org and repo sites (github.com/«org»/«repo»). There is no way to configure redirects manually here. Github can do some redirects if repos or orgs have been renamed but that is only for an unspecified timeframe and will also not help here as we link into the git repo paths here.

@hohwille
Copy link
Member

hohwille commented Sep 24, 2018

I analyzed the current state again and regenerated the site from the current code-base.
All we need to do is actually deploying the maven site to some location, if required update the base-URL according to that location and then we can close this issue.
Maven is designed such that the URLs point to the maven site itself. It therefore has specific conventions for generating and inheriting these URLs that are performed in the same way when the site is generated.
While on github we have the module names as folder that differ from the artifactIds the site will always use the artifactIds as folder names.
After all the pain with our homepage I would like to have some webspace where we can put the documentation and also archive official releases with maven site, release-notes and PDFs as a simple web-server without github pages and flooding any git history.

IMHO this is the only outstanding issue that is remaining.

And for the record: These URLs once worked correct, but the content behind it had been deleted.

@hohwille hohwille removed the easyfix label Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants