Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed DI water structure #1774

Conversation

turbomam
Copy link
Contributor

@turbomam turbomam commented Mar 20, 2024

I don't feel confident about how far out this should be axiomitized, or whether deionization should be thought of as a purification or as a material component separation

I haven't attempted to find a safe range of OBI ids yet.

CC @cmungall

@turbomam turbomam linked an issue Mar 20, 2024 that may be closed by this pull request
@turbomam turbomam marked this pull request as draft March 20, 2024 15:59
Copy link
Contributor

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use your ID range
  • Should be a subclass of ENVO:water
  • Add definitions
  • There is an argument for putting in ENVO but as this is primarily a material created artificially OBI is fine

@jamesaoverton
Copy link
Contributor

OBI doesn't have user ID ranges. Please use this Google Sheet to get an ID: https://docs.google.com/spreadsheets/d/1tpDrSiO1DlEqkvZjrDSJrMm7OvH9GletljaR-SDeMTI/edit#gid=224833299

We define ENVO imports in this file: https://github.com/obi-ontology/obi/blob/master/src/ontology/OntoFox_inputs/ENVO_input.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR 'deionized water' and 'water deionization process'
3 participants