Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making all definitions language tagged #1794

Closed
wants to merge 2 commits into from
Closed

Making all definitions language tagged #1794

wants to merge 2 commits into from

Conversation

dragon-ai-agent
Copy link

Fixes #1793

@jamesaoverton
Copy link
Contributor

This PR only changes obi-edit.owl, which includes a minority of OBI terms. To cover all OBI terms, ROBOT template strings would also have to be updated. I suppose it would also make sense to change other annotation properties, especially labels.

@cmungall
Copy link
Contributor

Good point, updated PR for definitions in templates

Do you want a separate PR for other APs?

Does it make sense to do for e.g.

<obo:IAO_0000119>bp</obo:IAO_0000119>

@sebastianduesing sebastianduesing self-assigned this Jun 24, 2024
@jamesaoverton
Copy link
Contributor

The second commit deleted tabs and broke the templates. @sebastianduesing will fix it.

@sebastianduesing sebastianduesing mentioned this pull request Jun 27, 2024
Merged
@jamesaoverton
Copy link
Contributor

Closing in favour of #1795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebastianduesing sebastianduesing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make language tags consistent
4 participants
@dragon-ai-agent @jamesaoverton @cmungall @sebastianduesing