Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Xrefs in human-view.obo #1615

Closed
rpwagner opened this issue Jun 4, 2020 · 4 comments
Closed

Invalid Xrefs in human-view.obo #1615

rpwagner opened this issue Jun 4, 2020 · 4 comments
Assignees
Labels

Comments

@rpwagner
Copy link

rpwagner commented Jun 4, 2020

While trying to parse the human terms ontology using Pronto I hit an error with some of the Xrefs that don't match the OBO format version 1.4 specification.

>>> from pronto import Ontology
>>> uberon = Ontology('http://purl.obolibrary.org/obo/uberon/subsets/human-view.obo')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/rpwagner/anaconda3/lib/python3.7/site-packages/pronto/ontology.py", line 154, in __init__
    cls(self).parse_from(_handle)
  File "/Users/rpwagner/anaconda3/lib/python3.7/site-packages/pronto/parsers/obo.py", line 38, in parse_from
    raise SyntaxError(s.args[0], location) from None
  File "http://purl.obolibrary.org/obo/uberon/subsets/human-view.obo", line 242452
    synonym: "intercalarium anterior process" EXACT [TAO:Bird and Mabee 2003]␊
                                                              ^
SyntaxError: expected QuotedString
>>> 
@balhoff
Copy link
Member

balhoff commented Jun 5, 2020

@wdahdul is this a publication? Could these xrefs be replaced with a DOI?

@rpwagner
Copy link
Author

rpwagner commented Jun 5, 2020

I should mention there were several like this, with spaces in the X-ref.

@rpwagner
Copy link
Author

rpwagner commented Jun 5, 2020

Here's the list of bad references that I found. The file I was comparing against was one I was cutting synonyms out of to use, so the values in the > file are likely very inaccurate. I don't see a pattern to the terms with bad references, unfortunately.

human-view.obo.bad-refs.diff.txt

@gouttegd
Copy link
Collaborator

Apparently the offending cross-references have been fixed, I can’t find any traces of them (or similarly bogus ones) now and Pronto has no troubles loading the human-view.obo product from the latest release.

Closing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants