-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxon disjoints missing from locally built uberon.owl #2533
Comments
I do see a disjoint axiom like that in #2367; can someone explain where they're used? |
Now I see that these axioms are present in the released |
This is so weird. In ext.owl they must be coming in from through CL or something.. Can you summarise the functional problem with these axioms missing? I think that the for the subset generation, which is the place using the taxon constraints are used in Uberon, some other owltools based step is invoked after the fact, but the disjointness axioms are not shipped out.. From your understanding, should the taxon disjointness axioms be present in the release? So that it works with, for example, your OBO taxon plugin? |
I think the taxon constraints should be working for any DL coherency check, not just to generate subsets. If you don't have axioms like To go further in helping out ELK here, we also need |
@cmungall Do you see any reason not to release the unfolded taxon constraints in Uberon? |
To be pedantic, axioms like
are not themselves taxon constraints. This is part of the axiomatization of NCBITaxon. The documentation for this is very buried: I have no problem in incorporating these in a merged release file accompanying the taxon constraints themselves. But be aware from the point of view of assembly non-redundant subsets of ontologies using base files, these would not be included. They should come from some kind of ncbitaxon-base, were such a thing to exist |
Action item:
|
This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken. |
This is not in the pipeline right now. We need to merge the A related issue that will fix this #2707 |
After refactoring the Makefile, the |
This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken. |
Taxon disjointness axioms are now included in |
Please correct me if I'm missing it, but as far as I can tell, the Uberon build doesn't use
taxslim-disjoint-over-in-taxon.owl
anywhere, or generate the axioms it contains, like:Without these axioms, taxon constraints don't do anything in OWL EL. I would expect to find these GCIs in the final Uberon product. I'm running into this while trying to test some edits for #2349.
The text was updated successfully, but these errors were encountered: