Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lacrimal #2804

Closed
meghalithic opened this issue Feb 10, 2023 · 9 comments · Fixed by #3292
Closed

lacrimal #2804

meghalithic opened this issue Feb 10, 2023 · 9 comments · Fixed by #3292
Assignees

Comments

@meghalithic
Copy link
Collaborator

Uberon term
lacrimal: UBERON:3010146 and lacrimal bone UBERON:0001680

Bug description

Both terms exist in Uberon but do not seem that different. Should one be used over the other?

@meghalithic
Copy link
Collaborator Author

@wdahdul and I are unsure which term we should use.

@meghalithic meghalithic assigned ghost Mar 21, 2023
@github-actions
Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@ghost
Copy link

ghost commented Nov 17, 2023

@megbalk, thank you for the issue and apologies for a delayed response.
I added this to the Uberon agenda for 20/11/2023. Please consider attending to discuss.

@ghost ghost removed their assignment Nov 17, 2023
@meghalithic
Copy link
Collaborator Author

@seger do you have any thoughts on this? @bvarner-ebi et al. suggested I ask you.

@seger
Copy link
Member

seger commented Dec 11, 2023

@megbalk I don't have any particular insights to offer. The work done on the old amphibian ontology (where the former term came from) was long ago. I'd probably vote to keep the latter term (UBERON:0001680) if I had to choose.

@meghalithic
Copy link
Collaborator Author

@anitacaron is it useful to have a tag "preferred term" you think?

@anitacaron
Copy link
Collaborator

It would be better to obsolete the term UBERON:3010146 and add the replaced_by annotation to UBERON:0001680. @aleixpuigb, can you comment here, please?

Copy link

This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Jun 10, 2024
@aleixpuigb aleixpuigb removed the Stale label Jun 10, 2024
@aleixpuigb aleixpuigb self-assigned this Jun 10, 2024
@aleixpuigb
Copy link
Collaborator

I agree lacrimal: UBERON:3010146 should be merged into lacrimal bone UBERON:0001680.

aleixpuigb added a commit that referenced this issue Jun 10, 2024
Fixes #2804 obsolete 'lacrimal' into 'lacrimal bone'
aleixpuigb added a commit that referenced this issue Jun 10, 2024
* Fixes #2804 obsolete 'lacrimal' into 'lacrimal bone'

Fixes #2804 obsolete 'lacrimal' into 'lacrimal bone'

* Fix wrong annotation property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants