-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bone marrow microvessel #2946
Conversation
We're running an Uberon release, please hold this PR until new release is out. |
@anitacaron OK |
def: "Microvessel located in the bone marrow, including arterioles and sinusoids." [PMID:32286470] | ||
is_a: UBERON:8410081 ! blood microvessel | ||
relationship: dc-contributor https://orcid.org/0000-0002-0819-0473 | ||
relationship: part_of UBERON:0007195 ! stroma of bone marrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider if 'bone marrow' is more appropriate than 'stroma of bone marrow'. The cross reference uses the term bone marrow.
If keeping 'stroma of bone marrow', I recommend updating the text definition to reflect that: "Microvessel that is part of the stroma of bone marrow..." and possibly the label too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bvarner-ebi I changed to 'bone marrow'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If then |
@bvarner-ebi OK, I understand that I should change to 'located in' some 'bone marrow’. I already merged and deleted the branch. Can I do a new PR without an issue? or should I create a new issue and then do the new PR? |
@paulacalipho, you can do a new branch and PR for this change and reference this PR without a new issue. |
@bvarner-ebi no worries! I will do that |
fixes #2945