Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bone marrow microvessel #2946

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

paulacalipho
Copy link
Contributor

fixes #2945

@paulacalipho paulacalipho self-assigned this Jun 26, 2023
@anitacaron
Copy link
Collaborator

We're running an Uberon release, please hold this PR until new release is out.

@paulacalipho
Copy link
Contributor Author

@anitacaron OK

@anitacaron anitacaron requested a review from a user July 19, 2023 09:04
def: "Microvessel located in the bone marrow, including arterioles and sinusoids." [PMID:32286470]
is_a: UBERON:8410081 ! blood microvessel
relationship: dc-contributor https://orcid.org/0000-0002-0819-0473
relationship: part_of UBERON:0007195 ! stroma of bone marrow
Copy link

@ghost ghost Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider if 'bone marrow' is more appropriate than 'stroma of bone marrow'. The cross reference uses the term bone marrow.

If keeping 'stroma of bone marrow', I recommend updating the text definition to reflect that: "Microvessel that is part of the stroma of bone marrow..." and possibly the label too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvarner-ebi I changed to 'bone marrow'

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comment.

Interestingly, based on the current axioms, it is inferred that this structure is a subclass of 'bone foramen', which does not seem accurate.

Screenshot 2023-07-19 at 14 33 38

Investigating this is probably outside the scope of this ticket and should be investigated in a separate ticket.

@paulacalipho paulacalipho merged commit 24e22ce into master Jul 24, 2023
1 check passed
@paulacalipho paulacalipho deleted the #2945-NTR-Bone-marrow-microvessel branch July 24, 2023 11:41
@ghost
Copy link

ghost commented Jul 24, 2023

Please see inline comment.

Interestingly, based on the current axioms, it is inferred that this structure is a subclass of 'bone foramen', which does not seem accurate.

Investigating this is probably outside the scope of this ticket and should be investigated in a separate ticket.

If ‘part of' some 'bone marrow’ is changed to'located in' some 'bone marrow’

then SubClass Of some ‘bone foramen’ is no longer inferred. It also matches the text definition.

@paulacalipho
Copy link
Contributor Author

@bvarner-ebi OK, I understand that I should change to 'located in' some 'bone marrow’. I already merged and deleted the branch. Can I do a new PR without an issue? or should I create a new issue and then do the new PR?

@ghost
Copy link

ghost commented Jul 24, 2023

@paulacalipho, you can do a new branch and PR for this change and reference this PR without a new issue.
Apologies for not making this suggestion before approval/merge.

@paulacalipho
Copy link
Contributor Author

@bvarner-ebi no worries! I will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTR: Bone marrow microvessel
2 participants